[Kde-pim] Review Request: Correctly restore the state of folder view

[Olivier Trichet]

> On 2009-05-05 13:51:13, Thomas McGuire wrote:
> > Hold on, don't ship!
> > This breaks config compatibilty, after this, the total column in KMail was not restored.
> 
> Olivier Trichet wrote:
>     I admit I overlooked this problem. But sincerly, this is a really small annoyance for a greater gain.
>     Currently if the state saved after the first run is not good for you, you'll have to correct it every time you run kmail.
>     
>     Or am I missing something ?
> 
> Thomas McGuire wrote:
>     The problem is with a fresh config, I get the bug that I can't resize the columns in the KMail folder tree. This works with an old config.
>     This patch makes loading the old config fail, and therefore introduces a fresh config, which means all all users suddenly get the resize bug in KMail.
>     The KMail bug should be fixed of course, but I don't know when I will have time for that.
>     
>     Why not introduce a new config key? You could still load the old state if the new config key is not present, but load the new key if it is there. That would solve the problem.
>     
>     (It is a pity that we can't use proper upgrade script because of the weird way of saving in the folder tree)

Let's try to fix kmail then.
The updated patch avoid that kmail set the resizeMode property of each and every column to QHeaderView::Stretch or QHeaderView::ResizeToContents. The qt doc says that then "The size cannot be changed by the user or programmatically" (http://doc.trolltech.com/4.5/qheaderview.html#ResizeMode-enum).


- Olivier


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/673/#review1063
-----------------------------------------------------------


On 2009-05-05 12:22:57, Olivier Trichet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/673/
> -----------------------------------------------------------
> 
> (Updated 2009-05-05 12:22:57)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This correct the restoring of the state of columns in folder view : size, visibility, position.
> Seems like the binary data QHeaderView::saveState() returns does not play nicely with KConfig.
> 
> 
> This addresses bugs 190230 and 190838.
>     https://bugs.kde.org/show_bug.cgi?id=190230
>     https://bugs.kde.org/show_bug.cgi?id=190838
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/folderview.cpp 963400 
>   trunk/KDE/kdepim/libkdepim/treewidget.cpp 963400 
> 
> Diff: http://reviewboard.kde.org/r/673/diff
> 
> 
> Testing
> -------
> 
> Tested with the folder view of kmail and knode, and with mime tree view in kmail.
> 
> Actually, the size was not tested with kmail's folderview because resizing seems to be broken in trunk...
> 
> 
> Thanks,
> 
> Olivier
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/