[Kde-pim] Cyclic link dependencies in kdepimlibs - how to resolve?

[Thomas McGuire]

Hi,

On Tuesday 05 May 2009 01:24:39 Christophe Giboudeaux wrote:
> On Tuesday 05 May 2009 00:40:10 Thomas McGuire wrote:
> > now that KPIMTextEdit is basically complete, I wanted to support images
> > in signatures.
> > The signature editor is in kpimidentities, so kpimidentities needs to
> > link to kpimtextedit so that the signature editor there can support
> > images.
> >
> > Problem is, kpimtextedit already links to kpimidentities, because it has
> > some functions to insert signatures into the text edit.
> >
> > So there is a link cycle between kpimtextedit and kpimidentities, and
> > CMake won't let me do that.
> >
> > Any idea how to resolve that? One idea would be to move all of
> > kpimtextedit (two classes at the moment) to kpimidentities and get rid of
> > the kpimtextedit library altogether.
> > The downside of this is that a text edit doesn't really fit there.
>
> Can you attach the diff to this thread please ? I'd like to test a few
> things

Here you go.
Although I think it is the best to move all signature-related functions to 
kpimidentities, like Volker suggests.

Regards,
Thomas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: link.diff
Type: text/x-patch
Size: 2281 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090505/0c275e8e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090505/0c275e8e/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/