[Kde-pim] Review Request: Warn user filter without actions is invalid

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/761/#review1195
-----------------------------------------------------------


There are valid use cases for filters having no filter actions or no filter criteria.

A filter without filter action can be used as stop filter, i.e. to stop processing of the following filters if certain criteria are met. One use case is disabling filtering temporarily by adding such a stop filter as first filter. I have closed the bug as WONTFIX.

Filters without filter criteria are commonly used for filters added to the Apply Filter menu. The Anti-Spam Wizard adds such filters.

Informing the user that no accounts are selected might be a good idea, though.

- Ingo


On 2009-05-25 06:43:55, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/761/
> -----------------------------------------------------------
> 
> (Updated 2009-05-25 06:43:55)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Current behaviour is to complain when saving a filter with no matching pattern, but having no action is allowed. This patch changes it complain if no action is specified or no matching pattern or, if applicable, no accounts are selected.
> 
> 
> This addresses bug 182581.
>     https://bugs.kde.org/show_bug.cgi?id=182581
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmfilter.cpp 972508 
> 
> Diff: http://reviewboard.kde.org/r/761/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/