[Kde-pim] Review Request: Correctly restore the state of folder view

[Olivier Trichet]

> On 2009-05-05 13:51:13, Thomas McGuire wrote:
> > Hold on, don't ship!
> > This breaks config compatibilty, after this, the total column in KMail was not restored.

I admit I overlooked this problem. But sincerly, this is a really small annoyance for a greater gain.
Currently if the state saved after the first run is not good for you, you'll have to correct it every time you run kmail.

Or am I missing something ?


- Olivier


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/673/#review1063
-----------------------------------------------------------


On 2009-05-05 12:22:57, Olivier Trichet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/673/
> -----------------------------------------------------------
> 
> (Updated 2009-05-05 12:22:57)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This correct the restoring of the state of columns in folder view : size, visibility, position.
> Seems like the binary data QHeaderView::saveState() returns does not play nicely with KConfig.
> 
> 
> This addresses bugs 190230 and 190838.
>     https://bugs.kde.org/show_bug.cgi?id=190230
>     https://bugs.kde.org/show_bug.cgi?id=190838
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/libkdepim/treewidget.cpp 963400 
> 
> Diff: http://reviewboard.kde.org/r/673/diff
> 
> 
> Testing
> -------
> 
> Tested with the folder view of kmail and knode, and with mime tree view in kmail.
> 
> Actually, the size was not tested with kmail's folderview because resizing seems to be broken in trunk...
> 
> 
> Thanks,
> 
> Olivier
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/