[Kde-pim] Review Request: Replaced KPassivePopup with KNotification

[Tom Albers]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/732/#review1167
-----------------------------------------------------------



/trunk/KDE/kdepim/akonadi/tray/dock.cpp
<http://reviewboard.kde.org/r/732/#comment732>

    Please make that i18nc("process: message","%1: %2", agent.name(), message) or something like that. For the RTL languages.



/trunk/KDE/kdepim/akonadi/tray/org.freedesktop.akonaditray.xml
<http://reviewboard.kde.org/r/732/#comment733>

    That means you need to change the akonadi agentbase.cpp or resourcebase.cpp files to not use this api, right?
    
    And the question is if this breaks API. I think it does, so a convenience function to merge those two might be a better solution.


- Tom


On 2009-05-21 07:04:35, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/732/
> -----------------------------------------------------------
> 
> (Updated 2009-05-21 07:04:35)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> I've replaced KPassivePopups with KNotifications.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akonadi/tray/dock.h 970973 
>   /trunk/KDE/kdepim/akonadi/tray/dock.cpp 970973 
>   /trunk/KDE/kdepim/akonadi/tray/org.freedesktop.akonaditray.xml 970973 
> 
> Diff: http://reviewboard.kde.org/r/732/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/