[Kde-pim] Review Request: Use the imapstreamparser in the handlers and the connection manager

[Andras Mantia]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/301/
-----------------------------------------------------------

(Updated 2009-03-14 10:39:19.559727)


Review request for KDE PIM.


Changes
-------

Updated diff, the main changes are: Handler doesn't read the command and akonadiconnection has both the old and the new version of reading from socket.
The reason is the failing unittest with the new version. I couldn't find why it fails when run via ctest, and not when running individually.
Use ctest -I 8,8 -V to see the failing test. It hangs after
akonadi-TES(18088) SetupTest::resourceSynchronized: Agent "akonadi_knut_resource_1" synchronized.

The problem is somewhere in the case when the default handler is called, the old way also work ONLY if the command is not read from the buffer.

To enable the new code, uncomment the following lines:
//  slotNewData2();
//  return;

I'm clueless right now about the solution, ideas are welcome.


Summary
-------

This patch removes the old ImapParser code from the handlers and changes the akonadiconnection to use the new parser. 


Diffs (updated)
-----

  /trunk/kdesupport/akonadi/server/src/imapstreamparser.h 939273 
  /trunk/kdesupport/akonadi/server/src/imapstreamparser.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/storage/querybuilder.cpp 939273 
  /trunk/kdesupport/akonadi/server/tests/unittest/handlertest.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/uid.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/uid.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/transaction.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/transaction.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/subscribe.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/subscribe.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/store.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/store.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/select.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/select.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/status.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/status.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/searchpersistent.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/searchpersistent.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/rename.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/rename.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/noop.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/login.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/login.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/logout.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/logout.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/modify.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/modify.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/noop.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/list.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/link.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/link.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/list.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/fetch.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/fetch.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/expunge.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/expunge.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/delete.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/delete.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/copy.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/copy.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/create.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/create.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/append.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/append.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/capability.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/capability.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/colcopy.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/colcopy.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/aklist.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/aklist.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler/akappend.h 939273 
  /trunk/kdesupport/akonadi/server/src/handler/akappend.cpp 939273 
  /trunk/kdesupport/akonadi/server/src/handler.h 939273 
  /trunk/kdesupport/akonadi/server/src/akonadiconnection.h 939273 
  /trunk/kdesupport/akonadi/server/src/akonadiconnection.cpp 939273 

Diff: http://reviewboard.kde.org/r/301/diff


Testing
-------


Thanks,

Andras

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/