[Kde-pim] Review Request: Incremental ItemSync should handle deletedItems with just remoteId the way it does for updates

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/410/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

ItemSync's incremental mode did not correctly handle items in its "removedItems" list if they had only a remoteId. Adding or updates work without knowing the unique item ID by doing a lookup based on remoteId.
This basically does exactly the same for removal, skipping items which neither have unique ID nor an remote ID mapping to a currently existing item.


Diffs
-----

  /trunk/KDE/kdepimlibs/akonadi/itemsync.cpp 944008 
  /trunk/KDE/kdepimlibs/akonadi/tests/itemsynctest.cpp 944008 

Diff: http://reviewboard.kde.org/r/410/diff


Testing
-------

Unittest


Thanks,

Kevin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/