[Kde-pim] Review Request: Krazy fixes and simple compiler warnings

Sun Mar 22 22:07:22 GMT 2009

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/398/#review559
-----------------------------------------------------------

Ship it!

Looks fine, although I only checked the KMail changes, only scrolled over over the rest.
Please add spaces inside parenthesis for our great KDE PIM coding style :)

trunk/KDE/kdepim/akregator/interfaces/feedstorage.h
<http://reviewboard.kde.org/r/398/#comment338>

    Why this change?

trunk/KDE/kdepim/akregator/plugins/onlinesync/onlinesyncplugin.cpp
<http://reviewboard.kde.org/r/398/#comment339>

    coding style: Q_UNUSED( list )
    Also in other places

- Thomas

On 2009-03-22 14:57:57, nik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/398/
> -----------------------------------------------------------
> 
> (Updated 2009-03-22 14:57:57)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Krazy fixes and simple compiler warnings for kdepim/.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/akonadiconsole/agentwidget.cpp 942895 
>   trunk/KDE/kdepim/akonadiconsole/rawsocketconsole.cpp 942895 
>   trunk/KDE/kdepim/akregator/configuration/akregator_config_appearance.h 942895 
>   trunk/KDE/kdepim/akregator/configuration/akregator_config_archive.h 942895 
>   trunk/KDE/kdepim/akregator/configuration/akregator_config_browser.h 942895 
>   trunk/KDE/kdepim/akregator/configuration/akregator_config_general.h 942895 
>   trunk/KDE/kdepim/akregator/interfaces/feedstorage.h 942895 
>   trunk/KDE/kdepim/akregator/interfaces/storagefactoryregistry.cpp 942895 
>   trunk/KDE/kdepim/akregator/plugins/onlinesync/akregator_config_onlinesync.h 942895 
>   trunk/KDE/kdepim/akregator/plugins/onlinesync/onlinesyncplugin.cpp 942895 
>   trunk/KDE/kdepim/akregator/plugins/onlinesync/sync/akregator.cpp 942895 
>   trunk/KDE/kdepim/akregator/plugins/onlinesync/sync/feedsync.cpp 942895 
>   trunk/KDE/kdepim/akregator/plugins/onlinesync/sync/googlereader.cpp 942895 
>   trunk/KDE/kdepim/akregator/plugins/onlinesync/sync/opml.cpp 942895 
>   trunk/KDE/kdepim/akregator/plugins/onlinesync/sync/subscriptionlist.cpp 942895 
>   trunk/KDE/kdepim/akregator/plugins/onlinesync/ui/configurationdialog.h 942895 
>   trunk/KDE/kdepim/akregator/plugins/onlinesync/ui/configurationdialogadd.h 942895 
>   trunk/KDE/kdepim/akregator/plugins/onlinesync/ui/configurationwidget.h 942895 
>   trunk/KDE/kdepim/akregator/src/addfeeddialog.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/akregator_part.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/article.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/articleformatter.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/articleviewer.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/browserframe.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/feed.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/feedlist.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/feedpropertiesdialog.h 942895 
>   trunk/KDE/kdepim/akregator/src/feedpropertiesdialog.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/frame.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/framemanager.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/mainwidget.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/notificationmanager.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/pageviewer.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/pluginmanager.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/progressmanager.h 942895 
>   trunk/KDE/kdepim/akregator/src/progressmanager.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/searchbar.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/speechclient.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/subscriptionlistmodel.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/subscriptionlistview.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/treenode.cpp 942895 
>   trunk/KDE/kdepim/akregator/src/treenodevisitor.cpp 942895 
>   trunk/KDE/kdepim/kaddressbook/views/configuretableviewdialog.cpp 942895 
>   trunk/KDE/kdepim/kaddressbook/xxport/csvimportdialog.cpp 942895 
>   trunk/KDE/kdepim/kaddressbook/xxport/eudora_xxport.cpp 942895 
>   trunk/KDE/kdepim/kaddressbook/xxport/gmx_xxport.cpp 942895 
>   trunk/KDE/kdepim/kaddressbook/xxport/gnokii_xxport.cpp 942895 
>   trunk/KDE/kdepim/kalarm/resources/resourcelocaldir.cpp 942895 
>   trunk/KDE/kdepim/kjots/bookshelf.cpp 942895 
>   trunk/KDE/kdepim/kjots/kjotscomponent.h 942895 
>   trunk/KDE/kdepim/kjots/kjotscomponent.cpp 942895 
>   trunk/KDE/kdepim/kjots/kjotsentry.cpp 942895 
>   trunk/KDE/kdepim/kjots/knowitimporter.cpp 942895 
>   trunk/KDE/kdepim/kmail/kmmessage.cpp 942895 
>   trunk/KDE/kdepim/kmail/messagecomposer.cpp 942895 
>   trunk/KDE/kdepim/kmailcvt/filter_evolution_v2.cxx 942895 
>   trunk/KDE/kdepim/kmailcvt/filter_kmail_maildir.cxx 942895 
>   trunk/KDE/kdepim/kmailcvt/filter_mailapp.cxx 942895 
>   trunk/KDE/kdepim/kmailcvt/filter_oe.cxx 942895 
>   trunk/KDE/kdepim/kmailcvt/filter_pmail.cxx 942895 
>   trunk/KDE/kdepim/kmailcvt/filter_sylpheed.cxx 942895 
>   trunk/KDE/kdepim/kmailcvt/filter_thunderbird.cxx 942895 
>   trunk/KDE/kdepim/kmailcvt/kimportpage.cpp 942895 
>   trunk/KDE/kdepim/kmailcvt/kselfilterpage.cpp 942895 
>   trunk/KDE/kdepim/knotes/knote.h 942895 
>   trunk/KDE/kdepim/knotes/knote.cpp 942895 
>   trunk/KDE/kdepim/knotes/knotealarmdlg.cpp 942895 
>   trunk/KDE/kdepim/knotes/knotebutton.cpp 942895 
>   trunk/KDE/kdepim/knotes/knoteconfigdlg.cpp 942895 
>   trunk/KDE/kdepim/knotes/knoteedit.cpp 942895 
>   trunk/KDE/kdepim/knotes/knotehostdlg.cpp 942895 
>   trunk/KDE/kdepim/knotes/knotesalarm.cpp 942895 
>   trunk/KDE/kdepim/knotes/knotesapp.cpp 942895 
>   trunk/KDE/kdepim/knotes/knoteslegacy.cpp 942895 
>   trunk/KDE/kdepim/knotes/knotesnetrecv.h 942895 
>   trunk/KDE/kdepim/knotes/knotesnetrecv.cpp 942895 
>   trunk/KDE/kdepim/knotes/knotesnetsend.cpp 942895 
>   trunk/KDE/kdepim/knotes/resourcelocal.cpp 942895 
>   trunk/KDE/kdepim/knotes/resourcelocalconfig.cpp 942895 
>   trunk/KDE/kdepim/knotes/resourcemanager.cpp 942895 
>   trunk/KDE/kdepim/korganizer/views/agendaview/koagendaitem.h 942895 
>   trunk/KDE/kdepim/kpilot/conduits/base/recordconduit.h 942895 
>   trunk/KDE/kdepim/kpilot/conduits/calendar/calendarconduit.h 942895 
>   trunk/KDE/kdepim/kpilot/conduits/contacts/contactsconduit.h 942895 
>   trunk/KDE/kdepim/kpilot/conduits/todo/todoconduit.h 942895 
>   trunk/KDE/kdepim/ksendemail/mailerservice.cpp 942895 
>   trunk/KDE/kdepim/ktimetracker/karmstorage.h 942895 
>   trunk/KDE/kdepim/ktimetracker/karmstorage.cpp 942895 
>   trunk/KDE/kdepim/ktimetracker/taskview.cpp 942895 
>   trunk/KDE/kdepim/libksieve/impl/parser.h 942895 
>   trunk/KDE/kdepim/libksieve/parser/lexer.cpp 942895 
>   trunk/KDE/kdepim/plugins/kmail/bodypartformatter/text_xdiff.cpp 942895 
>   trunk/KDE/kdepim/strigi-analyzer/ics/icsendanalyzer.h 942895 
>   trunk/KDE/kdepim/strigi-analyzer/ics/icsendanalyzer.cpp 942895 
>   trunk/KDE/kdepim/strigi-analyzer/vcf/vcfendanalyzer.h 942895 
>   trunk/KDE/kdepim/strigi-analyzer/vcf/vcfendanalyzer.cpp 942895 
>   trunk/KDE/kdepim/wizards/egroupwarewizard.cpp 942895 
>   trunk/KDE/kdepim/wizards/kolabwizard.cpp 942895 
> 
> Diff: http://reviewboard.kde.org/r/398/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> nik
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/