[Kde-pim] Review Request: Avoid change signals during load

Kevin Krammer kevin.krammer at gmx.at
Sun Mar 22 18:14:11 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/396/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

Allen experienced a slow down when loading Akonadi based calendars because each adding of an incidence triggered a view update. This was caused by the resource emitting resourceChanged().

So the resources have been changed to not emit changed signals during loading, i.e. only when changes occur during normal operations (receiving change notifications from Akonadi)


Diffs
-----

  /trunk/KDE/kdepim/kresources/akonadi/kabc/resourceakonadi.cpp 942863 
  /trunk/KDE/kdepim/kresources/akonadi/kabc/resourceakonadi_p.cpp 942863 
  /trunk/KDE/kdepim/kresources/akonadi/kcal/resourceakonadi.cpp 942863 
  /trunk/KDE/kdepim/kresources/akonadi/kcal/resourceakonadi_p.cpp 942863 
  /trunk/KDE/kdepim/kresources/akonadi/shared/resourceprivatebase.h 942863 
  /trunk/KDE/kdepim/kresources/akonadi/shared/resourceprivatebase.cpp 942863 
  /trunk/KDE/kdepim/kresources/akonadi/shared/sharedresourceprivate.h 942863 

Diff: http://reviewboard.kde.org/r/396/diff


Testing
-------


Thanks,

Kevin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list