[Kde-pim] Review Request: Port Knode folders/groups view to FolderTreeWidget

[Olivier Trichet]

> On 2009-03-02 14:38:50, Thomas McGuire wrote:
> > Can't really say much about the KNode code, except that it seems to work :)
> > Please remove the old kfoldertree.h/cpp afterwards.
> > Also, consider turning on alternate row colors.

What do you mean by writing "turning on alternate row colors" ? Using a user defined one ?
I wonder because, with this change, rows have the same alternate color there is currently in kmail.


- Olivier


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/223/#review335
-----------------------------------------------------------


On 2009-03-02 13:52:21, Olivier Trichet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/223/
> -----------------------------------------------------------
> 
> (Updated 2009-03-02 13:52:21)
> 
> 
> Review request for KDE PIM and Volker Krause.
> 
> 
> Summary
> -------
> 
> Adaptation of code except :
>  - new code in foldertreewidget.cpp to allow edition of items and custom elision of labels.
>  - remove the customized colors (bg, fg, text) in the view (there are themes for that purpose).
> 
> Still to be done
>  - need help to make the inline edition of item's name looks good.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/knode/kncollection.cpp 934350 
>   /trunk/KDE/kdepim/knode/kncollectionview.h 934350 
>   /trunk/KDE/kdepim/knode/kncollectionview.cpp 934350 
>   /trunk/KDE/kdepim/knode/kncollectionviewitem.h 934350 
>   /trunk/KDE/kdepim/knode/kncollectionviewitem.cpp 934350 
>   /trunk/KDE/kdepim/knode/knfolder.cpp 934350 
>   /trunk/KDE/kdepim/knode/kngroup.cpp 934350 
>   /trunk/KDE/kdepim/knode/knmainwidget.h 934350 
>   /trunk/KDE/kdepim/knode/knmainwidget.cpp 934350 
>   /trunk/KDE/kdepim/knode/knnntpaccount.cpp 934350 
>   /trunk/KDE/kdepim/libkdepim/foldertreewidget.h 934350 
>   /trunk/KDE/kdepim/libkdepim/foldertreewidget.cpp 934350 
> 
> Diff: http://reviewboard.kde.org/r/223/diff
> 
> 
> Testing
> -------
> 
> The view works as before when KNode is run standalone or run inside Kontact
> (except for inline edition appearance and color as describe above)
> 
> 
> Screenshots
> -----------
> 
> Alternate row color
>   http://reviewboard.kde.org/r/223/s/45/
> Alternate row color
>   http://reviewboard.kde.org/r/223/s/46/
> 
> 
> Thanks,
> 
> Olivier
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/