[Kde-pim] Review Request: Make "New incidence dialog" not ask if really to cancel when nothing was modified

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/229/#review354
-----------------------------------------------------------

Ship it!


Looks great!


trunk/KDE/kdepim/korganizer/koeventeditor.cpp
<http://reviewboard.kde.org/r/229/#comment216>

    I like incidenceModified() better than incidenceChanged().



trunk/KDE/kdepim/korganizer/koeventeditor.cpp
<http://reviewboard.kde.org/r/229/#comment215>

    sorta wish we had a different name for writeEvent|Todo|Journal()
    
    maybe fillEvent|Todo|Journal()? 
    
    anyway, that's not really related to the patch



trunk/KDE/kdepim/korganizer/koincidenceeditor.cpp
<http://reviewboard.kde.org/r/229/#comment217>

    How about changing the text to "This item has been modified. Do you really want to cancel? All changes will be lost."


- Allen


On 2009-03-04 07:35:29, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/229/
> -----------------------------------------------------------
> 
> (Updated 2009-03-04 07:35:29)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Currently when you edit an incidence and close the dialog or press cancel you will always be prompted with a "Do you really want to cancel" message, even if you didn't do any changes.
> 
> The patch compares the old incidence with the new one using the == operator, which compares everything.
> 
> 
> This addresses bugs 181981 and 184570.
>     https://bugs.kde.org/show_bug.cgi?id=181981
>     https://bugs.kde.org/show_bug.cgi?id=184570
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/korganizer/kotodoeditor.cpp 935115 
>   trunk/KDE/kdepim/korganizer/kojournaleditor.h 935115 
>   trunk/KDE/kdepim/korganizer/kojournaleditor.cpp 935115 
>   trunk/KDE/kdepim/korganizer/kotodoeditor.h 935115 
>   trunk/KDE/kdepim/korganizer/koincidenceeditor.h 935115 
>   trunk/KDE/kdepim/korganizer/koincidenceeditor.cpp 935115 
>   trunk/KDE/kdepim/korganizer/koeventeditor.h 935115 
>   trunk/KDE/kdepim/korganizer/koeventeditor.cpp 935115 
> 
> Diff: http://reviewboard.kde.org/r/229/diff
> 
> 
> Testing
> -------
> 
> Tested every property in journals, to-dos and events.
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/