[Kde-pim] Review Request: Support for the metadata-over-DBus API in Kmail

[Philip Van Hoof]

> On 2009-02-25 09:50:11, Kevin Krammer wrote:
> > /trunk/KDE/kdepim/kmail/mailmanagerimpl.cpp, line 139
> > <http://reviewboard.kde.org/r/168/diff/4/?file=1271#file1271line139>
> >
> >     Wouldn't it be easier to let the QDBus code generator also generate an QDBusInterface subclass for this?

I don't think this would be easier, no.


> On 2009-02-25 09:50:11, Kevin Krammer wrote:
> > /trunk/KDE/kdepim/libkdepim/CMakeLists.txt, line 122
> > <http://reviewboard.kde.org/r/168/diff/4/?file=1272#file1272line122>
> >
> >     It might be sufficient to move the file to the kmail source directory.
> >     
> >     It will probably not be implemented by any other application in the kdepim module and probably also not used.
> >

So what exactly should I change here?


> On 2009-02-25 09:50:11, Kevin Krammer wrote:
> > /trunk/KDE/kdepim/kmail/mailmanagerimpl.cpp, line 181
> > <http://reviewboard.kde.org/r/168/diff/4/?file=1271#file1271line181>
> >
> >     Personal preference again:
> >     if ( !subjects.isEmpty() )

ok


> On 2009-02-25 09:50:11, Kevin Krammer wrote:
> > /trunk/KDE/kdepim/kmail/mailmanagerimpl.cpp, line 168
> > <http://reviewboard.kde.org/r/168/diff/4/?file=1271#file1271line168>
> >
> >     Ok, this is mainly a personal style preference, but I would do
> >     
> >     for ( ; i < fcount; ++i ) {
> >       if ( processed >= max_per_dbus_call )
> >         break;
> >     }
> >     
> >     Indicate what the main processing condition is and under which circumstances the loop will be left earlier than that

      for ( ; i < fcount; ++i ) {
        const KMMsgBase *msg = folder->getMsgBase( i );

        processMsgBase( msg, subjects, predicatesArray, valuesArray );
        processed++;

        if ( processed >= max_per_dbus_call )
          break;
      }


> On 2009-02-25 09:50:11, Kevin Krammer wrote:
> > /trunk/KDE/kdepim/kmail/kmkernel.cpp, line 207
> > <http://reviewboard.kde.org/r/168/diff/4/?file=1269#file1269line207>
> >
> >     Is this instance deleted somewhere?

Following what was done for mMailService

KMKernel::~KMKernel ()
{
  ...

  delete mICalIface;
  mICalIface = 0;
  delete mMailService;
  mMailService = 0;
  delete mMailManager;
  mMailManager = 0;

  ...
}


- Philip


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/168/#review272
-----------------------------------------------------------


On 2009-02-25 06:10:18, Philip Van Hoof wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/168/
> -----------------------------------------------------------
> 
> (Updated 2009-02-25 06:10:18)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Support for the metadata-over-DBus API in Kmail.
> 
> https://bugs.kde.org/show_bug.cgi?id=185331
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=185331.
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=185331
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/CMakeLists.txt 917233 
>   /trunk/KDE/kdepim/kmail/kmkernel.h 917233 
>   /trunk/KDE/kdepim/kmail/kmkernel.cpp 917233 
>   /trunk/KDE/kdepim/kmail/mailmanagerimpl.h PRE-CREATION 
>   /trunk/KDE/kdepim/kmail/mailmanagerimpl.cpp PRE-CREATION 
>   /trunk/KDE/kdepim/libkdepim/CMakeLists.txt 917233 
>   /trunk/KDE/kdepim/libkdepim/interfaces/org.freedesktop.email.metadata.Manager.xml PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/168/diff
> 
> 
> Testing
> -------
> 
> Tested with this test tool:
> http://live.gnome.org/Evolution/Metadata?action=AttachFile&do=view&target=valaclientsample.vala
> 
> 
> Thanks,
> 
> Philip
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/