[Kde-pim] Review Request: Support for addressee fields which map to lists of value

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/387/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

Some fields of KABC::Addresssee, e.g. phone numbers, can appear multiple times, e.g. contact having more than one mobile phone.
As the bug report say, only the first is found during search in KAddressBook.

The SearchManager class basically iterates over all know KABC::Field instances and asks them for their value. For recurring fields this is just either the preferred one or the first one.

I am not sure the approach presented here is the way to go, maybe an iterator based approach of getting to the field's multiple values would be better, or maybe deprecate KABC::Field and use something totally new instead.

So this review request is more an RFC like entry to get some feedback on the overall problem.


This addresses bug 187499.
    https://bugs.kde.org/show_bug.cgi?id=187499


Diffs
-----

  /trunk/KDE/kdepimlibs/kabc/field.h 941086 
  /trunk/KDE/kdepimlibs/kabc/scripts/field.src.cpp 941086 
  /trunk/KDE/kdepim/kaddressbook/searchmanager.cpp 942415 

Diff: http://reviewboard.kde.org/r/387/diff


Testing
-------


Thanks,

Kevin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/