[Kde-pim] Review Request: Support for the metadata-over-DBus API in Kmail

[Thomas McGuire]

> On 2009-02-25 09:50:11, Kevin Krammer wrote:
> > /trunk/KDE/kdepim/kmail/mailmanagerimpl.h, line 50
> > <http://reviewboard.kde.org/r/168/diff/4/?file=1270#file1270line50>
> >
> >     the non-POD arguments should be passed as const reference, e.g.
> >     const QStringList &subjects
> >     
> >     The const pointer is OK
> 
>  wrote:
>     Hmm, const? subjects is being changed.

Still, it needs to be passed by reference, as otherwise you're modifying a _copy_ of subjects, not the original subjects, or am I mistaken here? Same for the other types.


> On 2009-02-25 09:50:11, Kevin Krammer wrote:
> > /trunk/KDE/kdepim/libkdepim/CMakeLists.txt, line 122
> > <http://reviewboard.kde.org/r/168/diff/4/?file=1272#file1272line122>
> >
> >     It might be sufficient to move the file to the kmail source directory.
> >     
> >     It will probably not be implemented by any other application in the kdepim module and probably also not used.
> >
> 
>  wrote:
>     So what exactly should I change here?

Not install it, I guess.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/168/#review272
-----------------------------------------------------------


On 2009-03-02 08:32:18, Philip Van Hoof wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/168/
> -----------------------------------------------------------
> 
> (Updated 2009-03-02 08:32:18)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Support for the metadata-over-DBus API in Kmail.
> 
> https://bugs.kde.org/show_bug.cgi?id=185331
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=185331.
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=185331
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/CMakeLists.txt 917233 
>   /trunk/KDE/kdepim/kmail/kmkernel.h 917233 
>   /trunk/KDE/kdepim/kmail/kmkernel.cpp 917233 
>   /trunk/KDE/kdepim/kmail/mailmanagerimpl.h PRE-CREATION 
>   /trunk/KDE/kdepim/kmail/mailmanagerimpl.cpp PRE-CREATION 
>   /trunk/KDE/kdepim/libkdepim/CMakeLists.txt 917233 
>   /trunk/KDE/kdepim/libkdepim/interfaces/org.freedesktop.email.metadata.Manager.xml PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/168/diff
> 
> 
> Testing
> -------
> 
> Tested with this test tool:
> http://live.gnome.org/Evolution/Metadata?action=AttachFile&do=view&target=valaclientsample.vala
> 
> 
> Thanks,
> 
> Philip
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/