[Kde-pim] Review Request: Make "New incidence dialog" not ask if really to cancel when nothing was modified

[Sergio Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/229/
-----------------------------------------------------------

(Updated 2009-03-04 17:39:36.054720)


Review request for KDE PIM.


Changes
-------

Changed incidenceChanged to incidenceModified.

Changed writeFoo to fillFoo.

Didn't change readFoo, it isn't as amibiguous as writeFoo.


Summary
-------

Currently when you edit an incidence and close the dialog or press cancel you will always be prompted with a "Do you really want to cancel" message, even if you didn't do any changes.

The patch compares the old incidence with the new one using the == operator, which compares everything.


This addresses bugs 181981 and 184570.
    https://bugs.kde.org/show_bug.cgi?id=181981
    https://bugs.kde.org/show_bug.cgi?id=184570


Diffs (updated)
-----

  trunk/KDE/kdepim/korganizer/koattendeeeditor.h 935348 
  trunk/KDE/kdepim/korganizer/koattendeeeditor.cpp 935348 
  trunk/KDE/kdepim/korganizer/koeditorattachments.h 935348 
  trunk/KDE/kdepim/korganizer/koeditorattachments.cpp 935348 
  trunk/KDE/kdepim/korganizer/koeditordetails.h 935348 
  trunk/KDE/kdepim/korganizer/koeditordetails.cpp 935348 
  trunk/KDE/kdepim/korganizer/koeditorfreebusy.h 935348 
  trunk/KDE/kdepim/korganizer/koeditorfreebusy.cpp 935348 
  trunk/KDE/kdepim/korganizer/koeditorgeneral.h 935348 
  trunk/KDE/kdepim/korganizer/koeditorgeneral.cpp 935348 
  trunk/KDE/kdepim/korganizer/koeditorgeneralevent.h 935348 
  trunk/KDE/kdepim/korganizer/koeditorgeneralevent.cpp 935348 
  trunk/KDE/kdepim/korganizer/koeditorgeneraljournal.h 935348 
  trunk/KDE/kdepim/korganizer/koeditorgeneraljournal.cpp 935348 
  trunk/KDE/kdepim/korganizer/koeditorgeneraltodo.h 935348 
  trunk/KDE/kdepim/korganizer/koeditorgeneraltodo.cpp 935348 
  trunk/KDE/kdepim/korganizer/koeditorrecurrence.h 935348 
  trunk/KDE/kdepim/korganizer/koeditorrecurrence.cpp 935348 
  trunk/KDE/kdepim/korganizer/koeventeditor.h 935348 
  trunk/KDE/kdepim/korganizer/koeventeditor.cpp 935348 
  trunk/KDE/kdepim/korganizer/koincidenceeditor.h 935348 
  trunk/KDE/kdepim/korganizer/koincidenceeditor.cpp 935348 
  trunk/KDE/kdepim/korganizer/kojournaleditor.h 935348 
  trunk/KDE/kdepim/korganizer/kojournaleditor.cpp 935348 
  trunk/KDE/kdepim/korganizer/kotodoeditor.h 935348 
  trunk/KDE/kdepim/korganizer/kotodoeditor.cpp 935348 

Diff: http://reviewboard.kde.org/r/229/diff


Testing
-------

Tested every property in journals, to-dos and events.


Thanks,

Sergio

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/