[Kde-pim] Review Request: Fix crash in kontact when unloading plugin

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/430/#review660
-----------------------------------------------------------

Ship it!


looks good

- Allen


On 2009-03-27 16:37:17, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/430/
> -----------------------------------------------------------
> 
> (Updated 2009-03-27 16:37:17)
> 
> 
> Review request for KDE PIM and Rafael Fernández.
> 
> 
> Summary
> -------
> 
> If you do some plugin loading and unloading you'll get a crash sooner or later. I patched the code, it's working now, but I don't know if I'm missing the bigger picture so I asked ereslibre to review this since I found his name in svn praise, so he'll probably know this code better than us :).
> 
> Basically, if you look at "it2" in the old code you'll see that it gets deleted regardless of the plugin type you're unloading. While debugging I saw for example the to-do's actionPlugin getting deleted when I unloaded something else.
> 
> 
> This addresses bug 180007.
>     https://bugs.kde.org/show_bug.cgi?id=180007
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kontact/src/mainwindow.cpp 945444 
> 
> Diff: http://reviewboard.kde.org/r/430/diff
> 
> 
> Testing
> -------
> 
> loading and unloading
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/