[Kde-pim] Review Request: tooltips and what's this for kmail

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/407/#review597
-----------------------------------------------------------


Thanks for taking this up, tooltips and whatsthis are very welcome!
I added some inline comments, please have a look.
And yeah, designer does this, very annoying. But we have to leave with it.


/trunk/KDE/kdepim/kmail/ui/composercryptoconfiguration.ui
<http://reviewboard.kde.org/r/407/#comment390>

    What is this text used for, actually? It was like that in the GUI before the changes, wasn't it?
    (I'm just wondering what the text property does)



/trunk/KDE/kdepim/kmail/ui/identitypage.ui
<http://reviewboard.kde.org/r/407/#comment386>

    Inconsitent: The "email" is not on the other buttons. Remove it here, I think.



/trunk/KDE/kdepim/kmail/ui/imapsettings.ui
<http://reviewboard.kde.org/r/407/#comment387>

    I think we say mail, not email.
    This needs to be fixed in all places.



/trunk/KDE/kdepim/kmail/ui/imapsettings.ui
<http://reviewboard.kde.org/r/407/#comment388>

    the <br/> tag shows up in the actual GUI.



/trunk/KDE/kdepim/kmail/ui/popsettings.ui
<http://reviewboard.kde.org/r/407/#comment389>

    Again, <br/> shows up in the GUI. Please check all places.


- Thomas


On 2009-03-24 13:27:53, rabauke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/407/
> -----------------------------------------------------------
> 
> (Updated 2009-03-24 13:27:53)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Add tooltips and some "What's this" to KMail's UI files.
> 
> Not sure why designer messed it up that much.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/ui/composercryptoconfiguration.ui 943090 
>   /trunk/KDE/kdepim/kmail/ui/identitypage.ui 943090 
>   /trunk/KDE/kdepim/kmail/ui/imapsettings.ui 943090 
>   /trunk/KDE/kdepim/kmail/ui/popsettings.ui 943090 
> 
> Diff: http://reviewboard.kde.org/r/407/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> rabauke
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/