[Kde-pim] Review Request: Assignment operaters should check for self assignment

[Sergio Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/224/#review333
-----------------------------------------------------------


Missing a couple of { }, it's in the coding style guide I think,

- Sergio


On 2009-03-02 13:48:55, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/224/
> -----------------------------------------------------------
> 
> (Updated 2009-03-02 13:48:55)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Just checking whether the passed object is actually an alias of the current one and return without doing any member assignment
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/kcal/attendee.cpp 934367 
>   /trunk/KDE/kdepimlibs/kcal/customproperties.cpp 934367 
>   /trunk/KDE/kdepimlibs/kcal/duration.cpp 934367 
>   /trunk/KDE/kdepimlibs/kcal/event.cpp 934367 
>   /trunk/KDE/kdepimlibs/kcal/freebusy.cpp 934367 
>   /trunk/KDE/kdepimlibs/kcal/freebusyperiod.cpp 934367 
>   /trunk/KDE/kdepimlibs/kcal/incidencebase.cpp 934367 
>   /trunk/KDE/kdepimlibs/kcal/journal.cpp 934367 
>   /trunk/KDE/kdepimlibs/kcal/period.cpp 934367 
>   /trunk/KDE/kdepimlibs/kcal/person.cpp 934367 
>   /trunk/KDE/kdepimlibs/kcal/resourcelocal.cpp 934367 
>   /trunk/KDE/kdepimlibs/kcal/todo.cpp 934367 
> 
> Diff: http://reviewboard.kde.org/r/224/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/