[Kde-pim] Review Request: "one off error for midsummer in holiday_se"

Christophe Giboudeaux cgiboudeaux at gmail.com
Wed Mar 11 03:40:05 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/269/#review453
-----------------------------------------------------------

Ship it!


Oops, didn't see a review had been created for this. I commited the fix already.
>From wikipedia:
midsommardagen:	The Saturday during the period 20–26 June.
midsommarafton:	The day before Midsummer's Day.

- Christophe


On 2009-03-10 18:33:58, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/269/
> -----------------------------------------------------------
> 
> (Updated 2009-03-10 18:33:58)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Here's a patch submited by Bengt Ahlgren at b.k.o for Swedish holidays.
> 
> Any Swedish dev wants to review?
> 
> I think the patch is right and will commit if we haven't any Swedish dev around:
> 
> http://www.timeanddate.com/calendar/custom.html?year=2009&country=21&month=6&lang=en&hol=825&wno=0&typ=1&display=1
> 
> 
> This addresses bug 186825.
>     https://bugs.kde.org/show_bug.cgi?id=186825
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kholidays/holidays/holiday_se 936902 
> 
> Diff: http://reviewboard.kde.org/r/269/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Current situation
>   http://reviewboard.kde.org/r/269/s/54/
> Patched situation
>   http://reviewboard.kde.org/r/269/s/55/
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list