[Kde-pim] Question about Kode

[Volker Krause]

On Saturday 21 March 2009 17:59:50 Christophe Giboudeaux wrote:
> On Saturday 21 March 2009 17:24:33 Cornelius Schumacher wrote:
> > On Saturday 21 March 2009 14:58:52 Christophe Giboudeaux wrote:
> > > On Saturday 21 March 2009 14:19:33 you wrote:
> > > > On Thursday 19 March 2009 00:08:25 Cornelius Schumacher wrote:
> > > > > I also noticed that the tests are disabled in kxml_compiler. I
> > > > > assume this is a late remnant of the cmake port. The tests are a
> > > > > bit tricky, because they involve compiling and running code
> > > > > generated by kxml_compiler itself. I don't really know how to do
> > > > > this correctly with cmake. Does somebody know how to do it?
> > > >
> > > > Can you review the following patch ?
> > > > The logic :
> > > > - Try to find an installed kxml_compiler
> > > > - if it's not found, use kxml_compiler.exe.bat or kxml_compiler.shell
> > >
> > > 2nd version.
> > > kxml_compiler wasn't found even if previously installed, it's now
> > > fixed. I also removed  KODE_XML_COMPILER_SHELL which didn't make sense
> > > after another coffee.
> >
> > How do I create the test executables? Do I need a special make call?
>
> There's nothing special to do. You can type make in the kode directory or
> directly in kxml_compiler/tests.
>
> > Also, shouldn't the logic be the other way around? That first a local
> > kxml_compiler.shell is used, and if not found the installed version is
> > taken? Otherwise you always would have to install before the tests would
> > give correct results after changing kxml_compiler.
>
> FindKode.cmake will never look for a kxml_compiler executable then :
>
> CMake doesn't check if kxml_compiler.shell exists or not, it just makes
> KODE_XML_COMPILER_EXECUTABLE point to this file. (otherwise, you would have
> to build kode without the tests  then recompile it again with the
> KDE4_BUILD_TESTS flag)
>
> Since the kxml_compiler will always be built before kxml_compiler/tests we
> can remove this line:
> find_program( KODE_XML_COMPILER_EXECUTABLE kxml_compiler )

Well, you could check if we are really building kxml_compiler by checking if a 
specific source file exists (like it was done in the original file in 
kdepim). Also, it might be worth looking at the kconfig_compiler macros in 
kdelibs, we basically have the same situation there.

regards
Volker

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090321/863ce679/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/