[Kde-pim] Review Request: Support for the metadata-over-DBus API in Kmail

[Philip Van Hoof]

> On 2009-03-02 06:20:30, Thomas McGuire wrote:
> > /trunk/KDE/kdepim/kmail/mailmanagerimpl.cpp, line 92
> > <http://reviewboard.kde.org/r/168/diff/4/?file=1271#file1271line92>
> >
> >     foreach is probably easier here, but that's only a style thing.
> >     Otherwise, use const here more
> 
>  wrote:
>      for ( const_iterator it = msg->tagList()->begin(); it != msg->tagList()->end(); ++it ) {
>         QString tag = (*it);
>         predicates.append( "KMail:MessageTag" );
>         values.append( tag );
>       }

  for ( KMMessageTagList::const_iterator it = msg->tagList()->begin(); it != msg->tagList()->end(); ++it ) { .. }


- Philip


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/168/#review318
-----------------------------------------------------------


On 2009-03-02 08:32:18, Philip Van Hoof wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/168/
> -----------------------------------------------------------
> 
> (Updated 2009-03-02 08:32:18)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Support for the metadata-over-DBus API in Kmail.
> 
> https://bugs.kde.org/show_bug.cgi?id=185331
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=185331.
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=185331
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/CMakeLists.txt 917233 
>   /trunk/KDE/kdepim/kmail/kmkernel.h 917233 
>   /trunk/KDE/kdepim/kmail/kmkernel.cpp 917233 
>   /trunk/KDE/kdepim/kmail/mailmanagerimpl.h PRE-CREATION 
>   /trunk/KDE/kdepim/kmail/mailmanagerimpl.cpp PRE-CREATION 
>   /trunk/KDE/kdepim/libkdepim/CMakeLists.txt 917233 
>   /trunk/KDE/kdepim/libkdepim/interfaces/org.freedesktop.email.metadata.Manager.xml PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/168/diff
> 
> 
> Testing
> -------
> 
> Tested with this test tool:
> http://live.gnome.org/Evolution/Metadata?action=AttachFile&do=view&target=valaclientsample.vala
> 
> 
> Thanks,
> 
> Philip
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/