[Kde-pim] Review Request: KOAgendaview::createDayLabels refactoring

[Shai Berger]

> On 2009-03-11 19:35:28, Sergio Martins wrote:
> > Do you have that crash before or after your patch? Do you have a backtrace/steps do reproduce?

The crash was after the patch. I looked at the backtrace and it was in the preferences dialog, but I don't have it and am on my way to bed. Steps to reproduce: Open KOrganizer (independent of Kontact), select "settings -> configure KOrganizedr", crash. Hope this helps, and sorry about the form, but I must get some sleep tonight.


- Shai


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/276/#review459
-----------------------------------------------------------


On 2009-03-11 19:27:31, Shai Berger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/276/
> -----------------------------------------------------------
> 
> (Updated 2009-03-11 19:27:31)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> A little refactoring in KOAgendaView, no functionality changes expected
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/korganizer/views/agendaview/koagendaview.h 938511 
>   trunk/KDE/kdepim/korganizer/views/agendaview/koagendaview.cpp 938511 
> 
> Diff: http://reviewboard.kde.org/r/276/diff
> 
> 
> Testing
> -------
> 
> No extensive testing done (functionality is broken anyway). It compiles and very basically runs. I get a crash on the preferences dialog (which I never touched), so it's hard to test better.
> 
> 
> Thanks,
> 
> Shai
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/