[Kde-pim] Review Request: KNode, make saving of the external editor setting possible again

[Michael Leupold]

> On 2009-03-27 08:22:31, Volker Krause wrote:
> > Wouldn't it make sense to add that to KUrlRequester in kdelibs as it affects all users of it?
> 
> Michael Leupold wrote:
>     Yes it might. I can try to push that but so far kdelibs seemed to be pretty restrictive about handling KUrls as QString (eg. KUrl::toString being private). I'll check if it's possible to get this into kdelibs.

Alright. The text property is in KUrlRequester now. Changes to KConfigDialogManager making it possible to actually use it are currently pending. I'll update this patch when everything's ready.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/429/#review646
-----------------------------------------------------------


On 2009-03-26 12:01:27, Michael Leupold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/429/
> -----------------------------------------------------------
> 
> (Updated 2009-03-26 12:01:27)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> KNode uses a KUrlRequester as the widget to enter the external editor into. Unfortunately KUrlRequester doesn't quite work with KConfigXT (at least not if you want the config type String). This patch subclasses KUrlRequester and adds a "text" property for use with KConfigXT. Both methods are simply delegated to the superclass.
> 
> I left the .ui strings as is so this could be backported to 4.2. Adapting the strings so they aren't broken is just a matter of opening in designer and saving again.
> 
> 
> This addresses bug 170672.
>     https://bugs.kde.org/show_bug.cgi?id=170672
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/knode/knaccountmanager.cpp 944639 
>   /trunk/KDE/kdepim/knode/knarticlefilter.cpp 944639 
>   /trunk/KDE/kdepim/knode/knconfig.cpp 944639 
>   /trunk/KDE/kdepim/knode/knconfigwidgets.h 944639 
>   /trunk/KDE/kdepim/knode/knconfigwidgets.cpp 944639 
>   /trunk/KDE/kdepim/knode/knconvert.cpp 944639 
>   /trunk/KDE/kdepim/knode/knfiltermanager.cpp 944639 
>   /trunk/KDE/kdepim/knode/knfolder.cpp 944639 
>   /trunk/KDE/kdepim/knode/knfoldermanager.cpp 944639 
>   /trunk/KDE/kdepim/knode/knnntpaccount.cpp 944639 
>   /trunk/KDE/kdepim/knode/postnewscomposerwidget_base.ui 944639 
>   /trunk/KDE/kdepim/knode/settings.cpp 944639 
> 
> Diff: http://reviewboard.kde.org/r/429/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/