[Kde-pim] Review Request: Polishing: icons for context menus, sortable identity list

[Ingo Klöcker]

On Sunday 08 March 2009, klebezettel at gmx.net wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/253/
> -----------------------------------------------------------
>
> Review request for KDE PIM.

Find a few comments below.

FYI: I didn't review the actual patch.


> Summary
> -------
>
> Hiya!
>
> Some simple polishing:
>
> ------------------------------
> Context-Menu of a message:
>     "Copy To", "Move To"
>         - these sub menus use the icons of the folderview
>
> Context-Menu of a folder:
>     "Copy Folder To"
>         - these sub menus use the icons of the folderview
>         - above entry "Copy to This Folder"
>           (e.g. in "Copy Folder To" -> "Local Folders")
>           is now a separator

Above "Copy to This Folder"? In KDE 3 this used to be the first entry 
with a separator below it.


> Context-Menu of a URL in the messsage viewer:
>     - Entry "Open URL" now uses the "document-open"
>       icon (like klinkstatus)
>
>       Note: "Save Links As..." is left without an icon.
>             khtml does not use any icon for this kind of
>             entry, too.
>
> Enable sorting of identity list in the preferences
>     - Incoming and outgoings accounts are sortable too,
>       why not this one? (I'm always confused because
>       my identities are not sorted)

The identities used to be sorted alphabetically in KDE 3 with the 
exception that the default identity was always listed first. Since the 
order of the identities influences the mechanism choosing an identity 
to use for a reply it makes sense to allow sorting. So I'm in favor of 
this change.


Regards,
Ingo



> ------------------------------
>
>
> Diffs
> -----
>
>   trunk/KDE/kdepim/kmail/identitylistview.cpp 936593
>   trunk/KDE/kdepim/kmail/kmreaderwin.cpp 936593
>   trunk/KDE/kdepim/kmail/mainfolderview.cpp 936593
>
> Diff: http://reviewboard.kde.org/r/253/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> nik
>
> _______________________________________________
> KDE PIM mailing list kde-pim at kde.org
> https://mail.kde.org/mailman/listinfo/kde-pim
> KDE PIM home page at http://pim.kde.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090308/28767bc3/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/