[Kde-pim] Review Request: Move name member from Akonadi::ResourceBase up to Akonadi::Agentbase

[Sascha Peilicke]

> On 2009-06-18 05:27:37, Volker Krause wrote:
> > Are you sure removing name()/setName() from ResourceBase is BC? If not they have to stay and forward to the new ones in AgentBase.
> 
> Sascha Peilicke wrote:
>     should be BC, they are not virtual and thus should not change instances vtable size when removed ...
> 
> Kevin Krammer wrote:
>     Yes, but isn't the class name part of the symbol name?
>

agreed, so I'll do what volker recommends. how about the signal in ResourceBase ?


- Sascha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/857/#review1346
-----------------------------------------------------------


On 2009-06-18 04:47:38, Sascha Peilicke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/857/
> -----------------------------------------------------------
> 
> (Updated 2009-06-18 04:47:38)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Currently only resources can have a name but there's no reason for agents to not have one too. This patch moves the corresponding member/methods/signals up the Akonadi::AgentBase class.
> 
> The name is mainly useful to distinguish multiple agents of the same type. Altough this would be possible also via their identifier, the latter lacks some sort of expressiveness (from an user's perspective) and thus does not look too nice.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/akonadi/agentbase.h 983389 
>   trunk/KDE/kdepimlibs/akonadi/agentbase.cpp 983389 
>   trunk/KDE/kdepimlibs/akonadi/agentbase_p.h 983389 
>   trunk/KDE/kdepimlibs/akonadi/agentinstance.cpp 983389 
>   trunk/KDE/kdepimlibs/akonadi/resourcebase.h 983389 
>   trunk/KDE/kdepimlibs/akonadi/resourcebase.cpp 983389 
> 
> Diff: http://reviewboard.kde.org/r/857/diff
> 
> 
> Testing
> -------
> 
> successfully compiled kdepimlibs and kdepim, restarted akonadi server, added/removed agents and resources, set the name of an agent.
> 
> no problems so far
> 
> 
> Thanks,
> 
> Sascha
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/