[Kde-pim] Review Request: Give user option to continue editing after being warned about invalid filter

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/851/#review1327
-----------------------------------------------------------

Ship it!


Looks good, please commit after the string freeze is lifted. I've made some small notes below.


/trunk/KDE/kdepim/kmail/kmfilterdlg.h
<http://reviewboard.kde.org/r/851/#comment848>

    Not important in this case, but in some cases boolean parameters should be avoided, see http://doc.trolltech.com/qq/qq13-apis.html#thebooleanparametertrap



/trunk/KDE/kdepim/kmail/kmfilterdlg.cpp
<http://reviewboard.kde.org/r/851/#comment847>

    for functions, put the { into a new line



/trunk/KDE/kdepim/kmail/kmfilterdlg.cpp
<http://reviewboard.kde.org/r/851/#comment849>

    I think I would prefer a standard "Cancel" button here, so I don't need to think as much.
    This is also what the composer does when exiting it with some text inside.


- Thomas


On 2009-06-16 10:17:32, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/851/
> -----------------------------------------------------------
> 
> (Updated 2009-06-16 10:17:32)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Add 'Discard' and 'Edit' buttons to message box to give user option of continuing to edit invalid filters rather than always discarding. Address usability issue raised in bug 196352.
> 
> 
> This addresses bug 196352.
>     https://bugs.kde.org/show_bug.cgi?id=196352
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmfilterdlg.h 982275 
>   /trunk/KDE/kdepim/kmail/kmfilterdlg.cpp 982275 
> 
> Diff: http://reviewboard.kde.org/r/851/diff
> 
> 
> Testing
> -------
> 
> Messagebox works as expected.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/