[Kde-pim] Review Request: Allow postgresql options in akonadi kcm

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/843/#review1361
-----------------------------------------------------------



/trunk/KDE/kdepim/akonadi/kcm/serverconfigmodule.h
<http://reviewboard.kde.org/r/843/#comment866>

    Just a style question, but I would prefer the name to be more like MySqlStoragePage (instead of *Object)
    
    Or maybe *PageBase and implement any page specific handling in a class called *Page, e.g. the config read/write parts



/trunk/KDE/kdepim/akonadi/kcm/serverconfigmodule.cpp
<http://reviewboard.kde.org/r/843/#comment865>

    I think it would be better to use QStackedWidget
    


- Kevin


On 2009-06-14 08:50:38, jgoday wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/843/
> -----------------------------------------------------------
> 
> (Updated 2009-06-14 08:50:38)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Mysql and Postgresql sections in the akondi kcm module
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akonadi/kcm/CMakeLists.txt 981968 
>   /trunk/KDE/kdepim/akonadi/kcm/serverconfigmodule.h 981968 
>   /trunk/KDE/kdepim/akonadi/kcm/serverconfigmodule.cpp 981968 
>   /trunk/KDE/kdepim/akonadi/kcm/serverconfigmodule.ui 981968 
>   /trunk/KDE/kdepim/akonadi/kcm/servermysqlstorage.ui PRE-CREATION 
>   /trunk/KDE/kdepim/akonadi/kcm/serverpsqlstorage.ui PRE-CREATION 
>   /trunk/KDE/kdepim/akonadi/kcm/serverstoragedriver.ui PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/843/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> MySQL options
>   http://reviewboard.kde.org/r/843/s/131/
> PostgreSQL options
>   http://reviewboard.kde.org/r/843/s/132/
> 
> 
> Thanks,
> 
> jgoday
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/