[Kde-pim] Review Request: Add an 'Add tag' filter action

Jonathan Armond jon.armond at gmail.com
Mon Jun 8 11:55:33 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/798/
-----------------------------------------------------------

(Updated 2009-06-08 03:55:33.368810)


Review request for KDE PIM.


Changes
-------

Thanks to Thomas for suggestions.


Summary
-------

Add a filter action for adding tags to messages. Create a KMCommand for adding/toggling tags. I had planned to use the KMCommand for the filter action but it seems newly arriving messages don't have a serial number so I couldn't find a clean way to do it.


This addresses bug 171204.
    https://bugs.kde.org/show_bug.cgi?id=171204


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/kmcommands.h 978277 
  /trunk/KDE/kdepim/kmail/kmcommands.cpp 978277 
  /trunk/KDE/kdepim/kmail/kmfilteraction.cpp 978277 
  /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 978277 

Diff: http://reviewboard.kde.org/r/798/diff


Testing
-------

Newly arrived filtering works. Manual filtering works.


Thanks,

Jonathan

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list