[Kde-pim] Review Request: Use KABC::ContactGroup for Kolab Proxy distribution lists

[Andras Mantia]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/805/#review1288
-----------------------------------------------------------


I have just one comment before saying ship it. It would be probably better to create a separate distribution list handler that inherits from the addressbook handler, and reimplement the methods that are different.

- Andras


On 2009-06-08 13:02:35, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/805/
> -----------------------------------------------------------
> 
> (Updated 2009-06-08 13:02:35)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Ths is mainly a draft.
> It has ugly parts, e.g. using KABC::StdAddressBook to resolve KABC::ContactGroup::ContactReference members.
> Any comments welcome
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/CMakeLists.txt 979040 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/addressbookhandler.h 979040 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/addressbookhandler.cpp 979040 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/contact.h 979040 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/contact.cpp 979040 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/distributionlist.h PRE-CREATION 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/distributionlist.cpp PRE-CREATION 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabbase.h 979040 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabbase.cpp 979040 
> 
> Diff: http://reviewboard.kde.org/r/805/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/