[Kde-pim] Review Request: Use KABC::ContactGroup for Kolab Proxy distribution lists

[Andras Mantia]

> On 2009-06-09 13:54:31, Andras Mantia wrote:
> > I have just one comment before saying ship it. It would be probably better to create a separate distribution list handler that inherits from the addressbook handler, and reimplement the methods that are different.
> 
> Kevin Krammer wrote:
>     I am not sure this is possible, but my understanding of Kolab is quite limited.
>     When I initially considered doing a separate handler, it looked to me like there could only be one handler per folder type and distributions lists are stored in the contacts folder.

Indeed, contacts and distribution lists are in the same imap folder. In that case we have to do like you did. Please commit, just don't forget to use fromUtf8() for the XML.


- Andras


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/805/#review1288
-----------------------------------------------------------


On 2009-06-08 13:02:35, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/805/
> -----------------------------------------------------------
> 
> (Updated 2009-06-08 13:02:35)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Ths is mainly a draft.
> It has ugly parts, e.g. using KABC::StdAddressBook to resolve KABC::ContactGroup::ContactReference members.
> Any comments welcome
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/CMakeLists.txt 979040 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/addressbookhandler.h 979040 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/addressbookhandler.cpp 979040 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/contact.h 979040 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/contact.cpp 979040 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/distributionlist.h PRE-CREATION 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/distributionlist.cpp PRE-CREATION 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabbase.h 979040 
>   trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabbase.cpp 979040 
> 
> Diff: http://reviewboard.kde.org/r/805/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/