[Kde-pim] Review Request: Install MIME type declaration for KABC::ContactGroup

Allen Winter winter at kde.org
Tue Jun 23 13:25:20 BST 2009



> On 2009-06-23 04:54:33, Allen Winter wrote:
> > Looks fine, but I don't see why we need the find_package(SharedMimeInfo)
> 
> Kevin Krammer wrote:
>     Without I get a CMAKE error at update_xdg_mimetypes() (near end of file)

ah, ok.  I didn't realize update_xdg_mimetypes was a cmake macro provided by FindSharedMimeInfo.cmake.  I wonder if we should make the min version 0.30 instead since that's the min version required by kdelibs and kdebase.  yes, let's do that.


- Allen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/879/#review1368
-----------------------------------------------------------


On 2009-06-23 04:13:59, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/879/
> -----------------------------------------------------------
> 
> (Updated 2009-06-23 04:13:59)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Install the SharedMimeInfo file for MIME type we now use for distribution lists
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/CMakeLists.txt 985643 
>   /trunk/KDE/kdepimlibs/kdepimlibs-mime.xml PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/879/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list