[Kde-pim] Review Request: Give the user some hint that an unexisting resource is configured

[Jason Kasper]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/787/#review1251
-----------------------------------------------------------



trunk/KDE/kdepim/kpilot/conduits/akonadibase/akonadisetupwidget.cc
<http://reviewboard.kde.org/r/787/#comment776>

    "new idea" -> "new ID"



trunk/KDE/kdepim/kpilot/conduits/akonadibase/akonadisetupwidget.cc
<http://reviewboard.kde.org/r/787/#comment777>

    "does not exist"



trunk/KDE/kdepim/kpilot/conduits/akonadibase/collectioncombobox.cc
<http://reviewboard.kde.org/r/787/#comment778>

    Our tab/space consistency is horrible in KPilot. =:( Can you use spaces here instead of a tab so that these 2 lines match?



trunk/KDE/kdepim/kpilot/conduits/akonadibase/collectioncombobox.cc
<http://reviewboard.kde.org/r/787/#comment779>

    Hm. I'm not sure why we would want to stop auto-selecting a valid collection for our user? Is it to make it obvious that they have to pick something? Just not sure how user-friendly that is of us. =:/


- Jason


On 2009-06-01 13:06:58, Bertjan Broeksema wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/787/
> -----------------------------------------------------------
> 
> (Updated 2009-06-01 13:06:58)
> 
> 
> Review request for KDE PIM, Douglas Harms and Jason Kasper.
> 
> 
> Summary
> -------
> 
> It seems to happen so now and than that people configure an Akonadi resource, sync with KPilot and than delete/create a new resource for the same file. The problem is that KPilot cannot know that it is the same file and the user *must* therefore reconfigure the conduit. This patch gives the user some hints about the fact that the configuration currently contains a resource that doesn't exist (anymore).
> 
> 
> This addresses bug 192187.
>     https://bugs.kde.org/show_bug.cgi?id=192187
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kpilot/conduits/akonadibase/akonadi-setup-widget.ui 976457 
>   trunk/KDE/kdepim/kpilot/conduits/akonadibase/akonadisetupwidget.cc 976457 
>   trunk/KDE/kdepim/kpilot/conduits/akonadibase/collectioncombobox.cc 976457 
> 
> Diff: http://reviewboard.kde.org/r/787/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bertjan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/