[Kde-pim] Review Request: Honor disable signature setting

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/842/#review1326
-----------------------------------------------------------

Ship it!


Thanks, I can indeed reproduce the bug.
Please commit after the little changes below (yeah, I'm micro-managing I guess...)


/trunk/KDE/kdepimlibs/kpimidentities/signatureconfigurator.cpp
<http://reviewboard.kde.org/r/842/#comment846>

    this variable can be const.



/trunk/KDE/kdepimlibs/kpimidentities/signatureconfigurator.cpp
<http://reviewboard.kde.org/r/842/#comment845>

    to get rid of (a tiny bit) of code duplication, can you move the setType() call in front of the return statement? With a "if ( sigType != Disabled )" in front, of course.


- Thomas


On 2009-06-15 02:44:19, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/842/
> -----------------------------------------------------------
> 
> (Updated 2009-06-15 02:44:19)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Fix bug where disabling signature didn't work because setText sets to Inlined
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/kpimidentities/signatureconfigurator.cpp 981764 
> 
> Diff: http://reviewboard.kde.org/r/842/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/