[Kde-pim] Review Request: [Fancy date format] "Today" not updated after midnight

[Olivier Trichet]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/661/
-----------------------------------------------------------

(Updated 2009-06-01 06:56:32.005876)


Review request for KDE PIM.


Changes
-------

Correct diff this time


Summary
-------

This change checks if the precalculed date/time of the end of the current day is still valid, otherwise it is updated.

The root of the issue is that KNode's headerview and KMail's MessageListView allocate only one instance of DateFormatter so that "mTodayOneSecondBeforeMidnight" is never updated.
The article view used static method from DateFormatter and the correct "mTodayOneSecondBeforeMidnight" is used.

Is it ok to call time() each time fancy() is called ?


This addresses bug 178035.
    https://bugs.kde.org/show_bug.cgi?id=178035


Diffs (updated)
-----

  trunk/KDE/kdepimlibs/kmime/kmime_dateformatter.cpp 976272 
  trunk/KDE/kdepimlibs/kmime/tests/CMakeLists.txt 976272 
  trunk/KDE/kdepimlibs/kmime/tests/kmime_dateformatter_fancy_bench.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/661/diff


Testing
-------

I reproduced the bug last night in KNode and validate the fix tonight.


Thanks,

Olivier

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/