[Kde-pim] Review Request: Implement %SIGNATURE template command.

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/846/#review1328
-----------------------------------------------------------


Looks good, except the case for HTML signatures, I would really prefer to insert the plain text instead.

HTML templates/HTML replies is another topic (much flamed about), see bug 86423. I think Edwin is working on this (??).


/trunk/KDE/kdepim/kmail/templateparser.cpp
<http://reviewboard.kde.org/r/846/#comment850>

    Hmm, this will look ugly, especially if the user doesn't spot this and then sends the message by accident.
    
    How about converting the HTML to plain text instead?
    
    You can use KMeditorPrivate::plainSignatureText() for this, but you probably need to move that to a place where you can access it, for example to the Signature class in kdepimlibs/kpimidentities.



/trunk/KDE/kdepim/kmail/templatesinsertcommand.cpp
<http://reviewboard.kde.org/r/846/#comment851>

    This probably needs context for the translators, as signature can also refer to cryptographic stuff.


- Thomas


On 2009-06-15 08:13:03, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/846/
> -----------------------------------------------------------
> 
> (Updated 2009-06-15 08:13:03)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Allow customized signature insertion location by implementing %SIGNATURE template command. Resolves ancient feature request 6376, and 159789.
> 
> 
> This addresses bugs 6376 and 159789.
>     https://bugs.kde.org/show_bug.cgi?id=6376
>     https://bugs.kde.org/show_bug.cgi?id=159789
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/templatesinsertcommand.h 982275 
>   /trunk/KDE/kdepim/kmail/templatesinsertcommand.cpp 982275 
>   /trunk/KDE/kdepim/kmail/templateparser.cpp 982275 
>   /trunk/KDE/kdepim/kmail/templateparser.h 982275 
> 
> Diff: http://reviewboard.kde.org/r/846/diff
> 
> 
> Testing
> -------
> 
> Insertion of signature in templates works. HTML does not - templates don't support HTML AFAICT.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/