[Kde-pim] Review Request: [Fancy date format] "Today" not updated after midnight

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/661/#review1250
-----------------------------------------------------------

Ship it!


Thanks for the benchmark test and for the fix of the fancy date update bug. Please commit your change to kmime_dateformatter.cpp (with the below mentioned change).


trunk/KDE/kdepimlibs/kmime/kmime_dateformatter.cpp
<http://reviewboard.kde.org/r/661/#comment775>

    The check mTodayOneSecondBeforeMidnight == 0 can be removed because time( 0 ) is always > 0.


- Ingo


On 2009-06-01 06:56:32, Olivier Trichet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/661/
> -----------------------------------------------------------
> 
> (Updated 2009-06-01 06:56:32)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This change checks if the precalculed date/time of the end of the current day is still valid, otherwise it is updated.
> 
> The root of the issue is that KNode's headerview and KMail's MessageListView allocate only one instance of DateFormatter so that "mTodayOneSecondBeforeMidnight" is never updated.
> The article view used static method from DateFormatter and the correct "mTodayOneSecondBeforeMidnight" is used.
> 
> Is it ok to call time() each time fancy() is called ?
> 
> 
> This addresses bug 178035.
>     https://bugs.kde.org/show_bug.cgi?id=178035
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kmime/kmime_dateformatter.cpp 976272 
>   trunk/KDE/kdepimlibs/kmime/tests/CMakeLists.txt 976272 
>   trunk/KDE/kdepimlibs/kmime/tests/kmime_dateformatter_fancy_bench.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/661/diff
> 
> 
> Testing
> -------
> 
> I reproduced the bug last night in KNode and validate the fix tonight.
> 
> 
> Thanks,
> 
> Olivier
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/