[Kde-pim] Review Request: Sort template Insert Command menu list

Jonathan Armond jon.armond at gmail.com
Thu Jun 11 08:43:01 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/809/
-----------------------------------------------------------

(Updated 2009-06-11 00:43:01.208326)


Review request for KDE PIM.


Changes
-------

Fixed according to Thomas' comments. I followed the I18N_NOOP style from kmsearchpatternedit.cpp.


Summary
-------

Template Insert Command menu is currently loosely sorted in English. This patch sorts it according to translated string. Also reduces code duplication.


This addresses bug 188394.
    https://bugs.kde.org/show_bug.cgi?id=188394


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/templatesinsertcommand.cpp 979894 

Diff: http://reviewboard.kde.org/r/809/diff


Testing
-------

Insert Command menu items are sorted and still work.


Thanks,

Jonathan

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list