[Kde-pim] Review Request: Move name member from Akonadi::ResourceBase up to Akonadi::Agentbase

[Kevin Krammer]

> On 2009-06-21 08:38:14, Kevin Krammer wrote:
> > trunk/KDE/kdepimlibs/akonadi/resourcebase.h, line 205
> > <http://reviewboard.kde.org/r/857/diff/2/?file=7389#file7389line205>
> >
> >     nameChanged() is a protected method which means it is a "public" symbol for subclasses.
> >     The change might be acceptable because signal/slot connections are created at runtime and nobody calls signals manually.
> >     But I am pretty sure it is not BC :(
> >

I think the only safe way is to avoid using the same names, e.g.

AgentBase::setAgentName(), AgentBase::agentName(), AgentBase::agentNameChanged()

them

ResourceBase::setName() -> AgentBase::setAgentName()
ResourceBase::name() -> AgentBase::agentName()

and in ResourceBase::ResourceBase()
connect(this, SIGNAL(agentNameChanged(QString)), this, SIGNAL(nameChanged(QString)));


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/857/#review1357
-----------------------------------------------------------


On 2009-06-18 12:53:38, Sascha Peilicke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/857/
> -----------------------------------------------------------
> 
> (Updated 2009-06-18 12:53:38)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Currently only resources can have a name but there's no reason for agents to not have one too. This patch moves the corresponding member/methods/signals up the Akonadi::AgentBase class.
> 
> The name is mainly useful to distinguish multiple agents of the same type. Altough this would be possible also via their identifier, the latter lacks some sort of expressiveness (from an user's perspective) and thus does not look too nice.
> 
> I'm unable to upload a newer patch, reviewboard's buggy, find it here: http://pastebin.ca/1465254
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/akonadi/agentbase.cpp 983389 
>   trunk/KDE/kdepimlibs/akonadi/agentbase_p.h 983389 
>   trunk/KDE/kdepimlibs/akonadi/agentinstance.cpp 983389 
>   trunk/KDE/kdepimlibs/akonadi/resourcebase.h 983389 
>   trunk/KDE/kdepimlibs/akonadi/resourcebase.cpp 983389 
>   trunk/KDE/kdepimlibs/akonadi/agentbase.h 983389 
> 
> Diff: http://reviewboard.kde.org/r/857/diff
> 
> 
> Testing
> -------
> 
> successfully compiled kdepimlibs and kdepim, restarted akonadi server, added/removed agents and resources, set the name of an agent.
> 
> no problems so far
> 
> 
> Thanks,
> 
> Sascha
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/