[Kde-pim] Review Request: Add parent, toplevel, index methods to KMime::Content

[Frank Osterfeld]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/826/#review1299
-----------------------------------------------------------


Two remarks:

The Content( Content* ) ctor should be explicit.

At least some of the added methods look like they should be const (but I know kmime is particular when it comes to const-ness, so it needs investigation).

- Frank


On 2009-06-11 05:38:00, Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/826/
> -----------------------------------------------------------
> 
> (Updated 2009-06-11 05:38:00)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Add some helper methods to KMime::Content to make application writer's life easier. In the mail reader I need to get the index of a Content, but that's possible only if I know the toplevel Content in the mime tree.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kmime/kmime_content.h 979973 
>   trunk/KDE/kdepimlibs/kmime/kmime_content.cpp 979973 
>   trunk/KDE/kdepimlibs/kmime/kmime_content_p.h 979973 
> 
> Diff: http://reviewboard.kde.org/r/826/diff
> 
> 
> Testing
> -------
> 
> No real testing yet, only compilation.
> 
> 
> Thanks,
> 
> Andras
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/