[Kde-pim] Review Request: fix segfault and memleak when removing attendees

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/852/#review1350
-----------------------------------------------------------

Ship it!


great work.  please mark your commit with the MERGE:e4 keyword

- Allen


On 2009-06-18 13:47:37, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/852/
> -----------------------------------------------------------
> 
> (Updated 2009-06-18 13:47:37)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> - Fix segfault when adding some attendees, then removing the first and clicking OK, as reported in bug 181944.
> - Fix some memleaks, the items in these lists: mDelAttendees, mNewAttendees weren't freed.
> 
> The editor used 2 list to keep track of deleted attendees.
> mDelAttendees has the list of deleted attendees, mNewAttendees had the list of inserted attendees.
> mNewAttendees's only purpose was to prevent the case when you delete an attendee and then re-add it, you don't want that attendee to receive an email.
> 
> I removed mNewAttendees because it's simpler just to remove the attendee from mDelAttendees when inserting. The mNewAttendees trick didn't even work if you delete, re-add and then re-delete again.
> 
> The segfault was because the original Attendee was being appended to mNewAttendees, and not a copy of it
> 
> 
> This addresses bug 181944.
>     https://bugs.kde.org/show_bug.cgi?id=181944
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/korganizer/koattendeeeditor.h 982439 
>   trunk/KDE/kdepim/korganizer/koattendeeeditor.cpp 982439 
> 
> Diff: http://reviewboard.kde.org/r/852/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/