[Kde-pim] Review Request: Fix for bug 190232

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/848/#review1325
-----------------------------------------------------------

Ship it!


Thanks for catching this, if seen quite some bug reports about it!
I committed it in r982805, but a bit different:

if ( mUserWhoField == whoField && !whoField.isEmpty() )
  return;

Side note: I think using a QString for the "who field" here instead of an enum is horrible style, but this can't be changed because of config compatibility, except if one writes an upgrade script.

- Thomas


On 2009-06-15 12:39:25, Frank Thieme wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/848/
> -----------------------------------------------------------
> 
> (Updated 2009-06-15 12:39:25)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This fixes the problem, that sent-mail folder show sender instead of receiverby default.
> Reason is that if the user has set "Default" whoField is empty and mWhoField == whoField on reading in config. So no defaults are set on starting kmail...
> 
> 
> This addresses bug 190232.
>     https://bugs.kde.org/show_bug.cgi?id=190232
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/kmfolder.cpp 982244 
> 
> Diff: http://reviewboard.kde.org/r/848/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frank
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/