[Kde-pim] Review Request: Apply template when switching identity in message composer

[Jonathan Armond]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/833/
-----------------------------------------------------------

(Updated 2009-06-18 03:28:33.617878)


Review request for KDE PIM.


Changes
-------

Correctly handle custom global templates, reply to selected text, reply-to-list uses reply-to-all template so should print "On %ODATE %ONAME wrote" rather than "On %ODATE you wrote". (NB reply-to-list is only invoked by R if folder->mailing list management contains an address or the message is from a list. Shortcut L should always work).


Summary
-------

Apply new template when switching identity in the message composer, as long the message has not been modified. NB: changing identity no longer marks message as modified.

Apply template to Forward As Attachment messages.

First attempt at fixing bug 143199.


This addresses bugs 143199, 179754 and 186843.
    https://bugs.kde.org/show_bug.cgi?id=143199
    https://bugs.kde.org/show_bug.cgi?id=179754
    https://bugs.kde.org/show_bug.cgi?id=186843


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/composer.h 983328 
  /trunk/KDE/kdepim/kmail/kmcommands.cpp 983328 
  /trunk/KDE/kdepim/kmail/kmcomposewin.h 983328 
  /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 983328 
  /trunk/KDE/kdepim/kmail/kmkernel.cpp 983328 
  /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 983328 
  /trunk/KDE/kdepim/kmail/templateparser.h 983328 
  /trunk/KDE/kdepim/kmail/templateparser.cpp 983328 

Diff: http://reviewboard.kde.org/r/833/diff


Testing
-------

Template properly parsed for new, reply, reply all and forward. Switches between custom, global and no templates properly. Doesn't switch after modifying message.


Thanks,

Jonathan

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/