[Kde-pim] Review Request: Fix Incidence::operator== when there are attachments

[Sergio Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/821/
-----------------------------------------------------------

(Updated 2009-06-13 12:02:53.693923)


Review request for KDE PIM.


Changes
-------

Added unittest.
Added @since.
Added != operator to Attachment


Summary
-------

If you have two identical incidences with attachments Incidence::operator== will return false.

This happens because we are comparing two ListBase object (attachments() == i2.attachments()).

ListBase holds items of class <T> but it's derived from QList<T*>, so when you compare two ListBases, QList<T*>::operator== get's called, and it compares addresses instead of values.

I implemented ListBase::operator== so we compare values.


Diffs (updated)
-----

  trunk/KDE/kdepimlibs/kcal/attachment.h 979860 
  trunk/KDE/kdepimlibs/kcal/attachment.cpp 979860 
  trunk/KDE/kdepimlibs/kcal/listbase.h 979860 
  trunk/KDE/kdepimlibs/kcal/tests/testattachment.cpp 979860 

Diff: http://reviewboard.kde.org/r/821/diff


Testing
-------

Compared attachments.


Thanks,

Sergio

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/