[Kde-pim] Review Request: Refactor Akonadi ical resource classes to allow inheritance by KAlarm resource

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1057/#review1657
-----------------------------------------------------------



/trunk/KDE/kdepim/akonadi/resources/ical/icalresource.cpp
<http://reviewboard.kde.org/r/1057/#comment1083>

    This will trigger a Krazy check saying that the first include should always be the header of the current source file.
    Just keep icalresource.h and include the .moc at the file end



/trunk/KDE/kdepim/akonadi/resources/ical/icalresourcebase.h
<http://reviewboard.kde.org/r/1057/#comment1084>

    if changed == true it means added?



/trunk/KDE/kdepim/akonadi/resources/ical/icalresourcebase.cpp
<http://reviewboard.kde.org/r/1057/#comment1085>

    Shouldn't the caption also be customizable?



/trunk/KDE/kdepim/akonadi/resources/ical/notes/notesresource.cpp
<http://reviewboard.kde.org/r/1057/#comment1086>

    Doesn't that overwrite any value previously configured by the user?



/trunk/KDE/kdepim/akonadi/resources/ical/notes/notesresourcemain.cpp
<http://reviewboard.kde.org/r/1057/#comment1087>

    What about just using the macro in the resource's .cpp file as usual and add the base catalogue in the base class' constructor?


- Kevin


On 2009-07-18 23:27:20, David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1057/
> -----------------------------------------------------------
> 
> (Updated 2009-07-18 23:27:20)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This is a refactoring of ICalResource discussed with Volker and Kevin at Akademy. It provides an ICalResourceBase class which is suitable for inheritance by KAlarm for its Akonadi resource. It also separates out the specialisations required by KNotes into another class inherited from ICalResource, rather than having KNotes code interspersed with the standard ICalResource code.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akonadi/kcal/kcalmimetypevisitor.h 998969 
>   /trunk/KDE/kdepim/akonadi/resources/ical/CMakeLists.txt 998969 
>   /trunk/KDE/kdepim/akonadi/resources/ical/Messages.sh 998969 
>   /trunk/KDE/kdepim/akonadi/resources/ical/icalresource.h 998969 
>   /trunk/KDE/kdepim/akonadi/resources/ical/icalresource.cpp 998969 
>   /trunk/KDE/kdepim/akonadi/resources/ical/icalresourcebase.h PRE-CREATION 
>   /trunk/KDE/kdepim/akonadi/resources/ical/icalresourcebase.cpp PRE-CREATION 
>   /trunk/KDE/kdepim/akonadi/resources/ical/icalresourcemain.cpp PRE-CREATION 
>   /trunk/KDE/kdepim/akonadi/resources/ical/notes/CMakeLists.txt PRE-CREATION 
>   /trunk/KDE/kdepim/akonadi/resources/ical/notes/notesmimetypevisitor.h PRE-CREATION 
>   /trunk/KDE/kdepim/akonadi/resources/ical/notes/notesmimetypevisitor.cpp PRE-CREATION 
>   /trunk/KDE/kdepim/akonadi/resources/ical/notes/notesresource.h PRE-CREATION 
>   /trunk/KDE/kdepim/akonadi/resources/ical/notes/notesresource.cpp PRE-CREATION 
>   /trunk/KDE/kdepim/akonadi/resources/ical/notes/notesresource.kcfg PRE-CREATION 
>   /trunk/KDE/kdepim/akonadi/resources/ical/notes/notesresourcemain.cpp PRE-CREATION 
>   /trunk/KDE/kdepim/akonadi/resources/ical/notes/settings.kcfgc PRE-CREATION 
>   /trunk/KDE/kdepim/akonadi/resources/ical/notesresource.desktop 998969 
> 
> Diff: http://reviewboard.kde.org/r/1057/diff
> 
> 
> Testing
> -------
> 
> Compiled, but not tested.
> 
> 
> Thanks,
> 
> David
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/