[Kde-pim] Review Request: Writting ical duration not up to spec

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/922/#review1452
-----------------------------------------------------------


I'm rejecting this patch.  Some versions of Outlook can't deal with durations expressed in weeks.  As the comment at the top of writeICalDuration() says: "...we know that some older tools do not properly support weeks. So we never set a week duration, only days".

There is nothing wrong with writing durations expressed in days only.

- Allen


On 2009-07-02 00:23:35, Alvaro Manera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/922/
> -----------------------------------------------------------
> 
> (Updated 2009-07-02 00:23:35)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> When writting the ical duraction the RFC says that an ical duration value must be  either weeks OR days/time, not both.
> 
> So a small patch to fix it.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 990270 
> 
> Diff: http://reviewboard.kde.org/r/922/diff
> 
> 
> Testing
> -------
> 
> All the test cases.
> 
> 
> Thanks,
> 
> Alvaro
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/