[Kde-pim] [patch] small code style modification

Ingo Klöcker kloecker at kde.org
Sun Jul 12 21:10:23 BST 2009


On Saturday 11 July 2009, Frank Osterfeld wrote:
> Radu,
>
> On Monday 06 July 2009 20:04:19 Radu Voicilas wrote:
> > Hi,
> >
> > Starting from this post http://www.kdedevelopers.org/node/3955 I
> > took a quick look over akregator's source and made small code style
> > modifications to article.cpp as my first, hopefully accepted,
> > patch. I am not sure if this could be considered for inclusion, but
> > I am sending it either ways.
>
> although I'd prefer your version in the code, I try to avoid
> whitespace changes just for the sake of identing style, as they break
> the SVN history, making it hard to follow who committed/did actual
> changes to the code. Thus I won't apply the patch.

FWIW, "svn blame -x -b foo" can be used to ignore whitespace changes. 
This should avoid the breakage of SVN history. The only downside is 
that this does not seem to be supported by websvn.


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090712/c3541edc/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list