[Kde-pim] Review Request: Refactor Akonadi ical resource classes to allow inheritance by KAlarm resource

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1057/
-----------------------------------------------------------

(Updated 2009-07-25 14:45:17.568307)


Review request for KDE PIM.


Changes
-------

New patch attached, to fix the errors Kevin noticed in the ICalResource constructor API comments and code.

NotesResource does need to be inherited from ICalResource, not ICalResourceBase, since it needs all ICalResource's functionality, plus a little bit more. ICalResourceBase will be inherited directly by KAlarm's resource.


Summary
-------

This is a refactoring of ICalResource discussed with Volker and Kevin at Akademy. It provides an ICalResourceBase class which is suitable for inheritance by KAlarm for its Akonadi resource. It also separates out the specialisations required by KNotes into another class inherited from ICalResource, rather than having KNotes code interspersed with the standard ICalResource code.


Diffs (updated)
-----

  /trunk/KDE/kdepim/akonadi/resources/ical/CMakeLists.txt 1001589 
  /trunk/KDE/kdepim/akonadi/resources/ical/Messages.sh 1001589 
  /trunk/KDE/kdepim/akonadi/resources/ical/icalresource.h 1001589 
  /trunk/KDE/kdepim/akonadi/resources/ical/icalresource.cpp 1001589 
  /trunk/KDE/kdepim/akonadi/resources/ical/icalresourcebase.h PRE-CREATION 
  /trunk/KDE/kdepim/akonadi/resources/ical/icalresourcebase.cpp PRE-CREATION 
  /trunk/KDE/kdepim/akonadi/resources/ical/icalresourcemain.cpp PRE-CREATION 
  /trunk/KDE/kdepim/akonadi/resources/ical/notes/CMakeLists.txt PRE-CREATION 
  /trunk/KDE/kdepim/akonadi/resources/ical/notes/notesresource.h PRE-CREATION 
  /trunk/KDE/kdepim/akonadi/resources/ical/notes/notesresource.cpp PRE-CREATION 
  /trunk/KDE/kdepim/akonadi/resources/ical/notes/notesresource.kcfg PRE-CREATION 
  /trunk/KDE/kdepim/akonadi/resources/ical/notes/settings.kcfgc PRE-CREATION 
  /trunk/KDE/kdepim/akonadi/resources/ical/notesresource.desktop 1001589 

Diff: http://reviewboard.kde.org/r/1057/diff


Testing
-------

Compiled, but not tested.


Thanks,

David

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/