[Kde-pim] Review Request: Improve focus handling (akregator)
Frank Osterfeld
frank.osterfeld at gmail.com
Tue Jul 14 15:01:55 BST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1002/#review1585
-----------------------------------------------------------
Ship it!
Thanks! I applied the focus part. For the "switch to maintab on next/prev article", it was actually already fixed in the 4.2 branch, so I forwardported the fix.
- Frank
On 2009-07-12 19:43:33, Alexander Elbs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1002/
> -----------------------------------------------------------
>
> (Updated 2009-07-12 19:43:33)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> - Force focus to always reach the articleviewer, even if in subscriptionlist has been clicked, fixes bug 124486
> - If another tab is active and next/prev article is choosen activate tab 0 (article list+view)
>
> (Feel free to commit if patch is good, no svn account.)
>
>
> This addresses bug 124486.
> https://bugs.kde.org/show_bug.cgi?id=124486
>
>
> Diffs
> -----
>
> trunk/KDE/kdepim/akregator/src/actionmanager.h 988800
> trunk/KDE/kdepim/akregator/src/actionmanagerimpl.h 988800
> trunk/KDE/kdepim/akregator/src/actionmanagerimpl.cpp 988800
> trunk/KDE/kdepim/akregator/src/articlelistview.h 988800
> trunk/KDE/kdepim/akregator/src/articlelistview.cpp 988800
> trunk/KDE/kdepim/akregator/src/mainwidget.cpp 988800
> trunk/KDE/kdepim/akregator/src/subscriptionlistview.cpp 988800
>
> Diff: http://reviewboard.kde.org/r/1002/diff
>
>
> Testing
> -------
>
> - Keys like Up, Down, Pgup, Pgdown always reach the khtml part.
> - Left, Right, +, - switch back to tab 0
>
>
> Thanks,
>
> Alexander
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list