[Kde-pim] Review Request: new kmail filter : add to address book

[David Boosalis]

As a casual observer I can't help but notice how much screen real-estate
this dialog takes.  One area that can be reduced is the filter column on the
left. It looks like the 4 buttons on the bottom are whats making it so big.
Why not add another row of  buttons making it two rows plus one row for the
arrows.

Does anyone really need 50-60 charactors for a filter, and is giving up one
or two rows of filters for the second row of buttons a great loss when you
have room for 20 filters.

Likewise the combo box seems to be taking up a lot of room, maybe there is a
string  of humoungous length in its list ?  But it looks like it is very big
at the expense of the text field to the right.

Other then that it looks very good. Thanks for making the improvements

-David


On Wed, Jul 15, 2009 at 5:32 PM, Bruno Bigras <bigras.bruno at gmail.com>wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1038/
> -----------------------------------------------------------
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> This is a port of a commit by Christian Schaarschmidt
> https://bugs.kde.org/show_bug.cgi?id=47333#c19 from the kdepim-3.5.5+
> branch.
>
> It add an "add to address book" filter action.
>
> I tried to make the ui look better when the window is not maximized (see
> the two screenshots) but the first combo box (the one to select "From",
> "To", "CC", "BCC") don't look so good in the center.
>
>
> This addresses bug 47333.
>    https://bugs.kde.org/show_bug.cgi?id=47333
>
>
> Diffs
> -----
>
>  /trunk/KDE/kdepim/kmail/kmfilteraction.cpp 997552
>
> Diff: http://reviewboard.kde.org/r/1038/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> before
>  http://reviewboard.kde.org/r/1038/s/143/
> after
>  http://reviewboard.kde.org/r/1038/s/144/
>
>
> Thanks,
>
> Bruno
>
> _______________________________________________
> KDE PIM mailing list kde-pim at kde.org
> https://mail.kde.org/mailman/listinfo/kde-pim
> KDE PIM home page at http://pim.kde.org/
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/