[Kde-pim] Review Request: Change KPilot settings dialog to allow syncing from the subfolder of a resource

[Robert Marmorstein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1039/#review1654
-----------------------------------------------------------


bbroeksema noticed that when opening the configuration dialog a second time (after choosing a collection), there is no indication which collection is the current one.  I've played with this for awhile with no luck.  However, this buggy behavior exists with the combobox as well, so it is not a regression.  Can we commit these changes and then work on that behavior separately?

- Robert


On 2009-07-16 11:20:12, Robert Marmorstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1039/
> -----------------------------------------------------------
> 
> (Updated 2009-07-16 11:20:12)
> 
> 
> Review request for KDE PIM, Jason Kasper and Bertjan Broeksema.
> 
> 
> Summary
> -------
> 
> This patch addresses bug #181558 (cannot sync from subfolder of a resource).  The problem was simple: kpilot only shows a combobox consisting of top-level items.  But resources like the Kolab resource that contain subfolders cannot sync to the topevel item --only to the individual folders.  This patch replaces the combobox widget with a treeview.  It's a little hacky, but it works -- I can successfully sync my Palm LifeDrive to my Kolab server!
> 
> I'm sure there are plenty of issues with this patch, so please don't be gentle -- I want to get this one right!
> 
> 
> This addresses bug 181558.
>     https://bugs.kde.org/show_bug.cgi?id=181558
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kpilot/conduits/akonadibase/CMakeLists.txt 997687 
>   trunk/KDE/kdepim/kpilot/conduits/akonadibase/akonadisetupwidget.h 997687 
>   trunk/KDE/kdepim/kpilot/conduits/akonadibase/akonadisetupwidget.cc 997687 
>   trunk/KDE/kdepim/kpilot/conduits/akonadibase/collectioncombobox.h 997687 
>   trunk/KDE/kdepim/kpilot/conduits/akonadibase/collectioncombobox.cc 997687 
> 
> Diff: http://reviewboard.kde.org/r/1039/diff
> 
> 
> Testing
> -------
> 
> Compiled, ran, and successfully sync'ed a Palm LifeDrive with one of the subfolder on my Kolab server using the Kolab Proxy resource.
> 
> 
> Screenshots
> -----------
> 
> before
>   http://reviewboard.kde.org/r/1039/s/145/
> after
>   http://reviewboard.kde.org/r/1039/s/147/
> 
> 
> Thanks,
> 
> Robert
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/